:Click() error when TButton is disabled

[Maurilio Viana]

Antonio, I found a little bug in TButton class using bWhen clause and Click method:
If bWhen clause is invalid but I do oBtn:Click() the bAction referred to oBtn is executed, a little sample:

redefine button oBtn ... of oDlg action AnyAction()
oBtn:bWhen := {|| .F. }

oDlg:bKeyDown := {|k| if(k=VK_F9, oBtn:Click(),) } // F9 fire action

function AnyAction()
? "oBtn was clicked"
return( Nil )

To solve I did: (In TButton.prg)


METHOD Click() CLASS TButton
if ! ::lProcessing
if ::bWhen # Nil .and. ! eval( ::bWhen )
return( Nil )
endif
(...)

--------------

*** I don't tested if it occur in other button controls like TBtnBmp, etc.

Regards,
Maurilio

[Antonio Linares]

Maurilio,

Thanks

This way seems a little better:

Code: Select all

   if ! ::lProcessing
   
      ::lProcessing = .t.
      
      if ::bWhen != nil .and. ! Eval( ::bWhen ) 
         ::lProcessing = .f.
         return nil 
      endif    
      ...

[Maurilio Viana]

Thanks, Antonio!

Regards,
Maurilio